Repository navigation
CLP-1110 Rerun dependent test suites when shared code and fixtures change - #211
frederic-tingaud-sonarsource wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · Workflow triggers now run additional suites and Jira sandbox integration on master. Adds path filters to six Jira test suites to watch ✅ 1 closed✅ Quality: New test-all entries run twice on master pushes
Verification Rules 3/3 metFunctional validation No results Rules 3 passed
Auto-approval Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |



Part of CLP-910.
A test suite that does not run when its dependencies change is not much better
than one that cannot fail. Several suites here exercise
shared/andtest-fixtures/jira/, but their triggers only watch their own action directory,so a change to the shared code did not rerun them.
shared/**was watched by one suite out of sevenThese all import
jira_commonorpath_utils, and none of them listedshared/**:test-create-jira-release-tickettest-create-jira-versiontest-get-jira-release-notestest-release-jira-versiontest-resolve-ktlo-epictest-update-release-ticket-statusOnly
test-create-integration-tickethad it. Added to both thepull_requestand
pushfilters of the other six.The KTLO fixture filter was too narrow
test-resolve-ktlo-epicwatched two specific files:but both of those import
jira_client.py, and the job installstest-fixtures/jira/requirements.txt. A change to either would not have rerunit. Replaced with
test-fixtures/jira/**.Nothing caught this later either
test-all.ymlruns only on push tomasterand on dispatch — there is nopull_requesttrigger — so a PR editingshared/jira_common.pyran two suitesand the other six only broke after merge. It was also missing five suites
entirely, so master did not cover them either. All five are now wired in:
test-bump-versionworkflow_calltrigger, so it could not be called at all — addedtest-jira-fixturescontents: read,id-token: writetest-notify-failureid-token: write,actions: readtest-resolve-ktlo-epiccontents: read,id-token: writetest-update-plugins-deployerI did not add a
pull_requesttrigger totest-all.yml. The path filtersare what the PR-time gap actually needed, and running all 22 suites on every PR
is a much bigger change than this ticket calls for.
One thing to decide before merging
test-resolve-ktlo-epic'sintegration-testhits the Jira sandbox and, unliketest-jira-fixtures, it has nocontinue-on-error. Wiring it intotest-all.ymltherefore creates a new way for master to go red on sandboxflakiness rather than on a real regression. I have included it because leaving
suites out of "Test All Actions" is the gap being fixed, but it is a one-line
removal if you would rather not take that exposure — or a reason to give that
job the same
continue-on-errortreatment its sibling already has.Verification
Checked mechanically rather than by eye, after the change:
test-*.ymlon disk is now referenced bytest-all.yml(nonemissing).test-all.ymlcalls declaresworkflow_call(nonemissing) —this is what caught
test-bump-version.jira_common/path_utilsnow hasshared/**in both itspull_requestandpushfilters.The one remaining gap is
sonar-update-center-release: it importsshared/and has no test workflow at all, so there is no trigger to fix. Out of scope
here, but worth a ticket.
🤖 Generated with Claude Code